Week 11

 Justin review: 

  • Variable names, are they meaningful and clear?

    • Variable names are meaningful and clear

  • Logic that could be more efficient

    • Logic looks sound. Selects a random word for guessed word, which is a neat solution

  • Unused imports or warnings.

    • No unused imports, one one warning present

  • Clear formatting

    • Formatting is good. Just one small nitpick: add spaces before ‘(‘ and after ‘{‘ i.e. if(debug){-> if (debug) {

  • Are there comments?

    • All class methods have comments

  • Which unit tests pass?

    • All unit tests pass


Mariah review:

  • Variable names, are they meaningful and clear?

    • Variable names are meaningful and clear. Just one small nitpick: Scanner sc → Scanner scanner

  • Logic that could be more efficient

    • Logic looks sound. Only improvement I can think of is selecting a random word for the guessed word, as presented by Justin’s code

  • Unused imports or warnings.

    • No unused imports, only one warning present

  • Clear formatting

    • Formatting is good. Just one small nitpick: add space after ‘)’ i.e. public int exit(){ → public int exit() {

  • Are there comments?

    • All class methods have comments placed above + additional comments placed within method

  • Which unit tests pass?

    • All unit tests pass


Summary for my feedback:
  • Logic is clear, unit tests pass, some issues with formatting.
Trends:
  • Everyone's code was sound, although I did see one warning that was present in everyone's code, but it was probably not a problem.

  1. What improvements would you make to your code/what was suggested? 
    1. I would make sure the formatting of my output was clearer
  2. Which unit tests were the hardest to pass?
    1. I think checkLose() was the hardest one to pass since one of my indexes were off by one.
  3. How do the existing tests function and could they be improved?
    1. Do the existing unit tests cover the full range of the sub classes?
      1. The tests appear to cover most of the class methods
    2. How would you change the unit tests?
      1. Keep in mind I do not want them to change but this doesn't mean I think they are perfect.  Reading through the tests is a good way to learn what the code should do thinking about how to test the codeis a good way to learn how to make tests.
        1. Maybe add more possible words to the test file to test against.
  4. What did you struggle with?
    1. Maybe getting some of the tests to pass
  5. What did one of your teammates struggle with?
    1. No clear struggles, appeared to go smoothly
  6. Was any part of the code a struggle for YOU?
    1. Set up one of my variable initializations incorrectly, although I spotted it after using the debugger.
  7. Was any part of writing the code easy for YOU?
    1. Yes, the getters/setters
  8. What was your biggest HW1 victory?
    1. Probably getting the unit tests to pass

Comments

Post a Comment

Popular posts from this blog

Week 5

 Part 1 Support Teammates' goals. Teammate comment (Ysabelle):  CST300 Week 4 Second comment (Faith):  Week 4 Learning Journal Part 2 Possible Capstone. I am mainly interested in mobile development, so I think some possible capstones I could work on could have the goal of making user's life more convenient.  An application for businesses to create a virtual loyalty card which allows them to send a text message of a user's QR, so they can scan their card and "punch" it. An application for users to track their workouts. They will be able to create custom workouts and track sets, rest time, reps, weights, etc.  A third idea could be working on an existing application that allows open contributions from students. Part 3 Learning Journal AI In Writing Using AI to complement your writing can benefit you by improving your reading efficiency and content creation. Instructive prompting: Used to guide your AI to a specific task. Output must be inspected to ensure it is re...
Read more

Week 4

Part 1 Educational Goals. My main educational goal is to achieve my bachelor's degree in computer science in 2 years. Another educational goal of mine is to do well in my upper division classes so I can be prepared for a career in software development. I would also like to strengthen my collaboration skills through the use of group projects.  Part 2 Career Goals. One of my main career goals is to become a professional software developer after graduation. I hope to leverage my current internship as an Android developer to find a new internship next summer, so I can explore different fields in software development. Part 3 Guess ETS percentile. If I had to guess, I think I would be in the 70th percentile. I feel pretty comfortable with programming, but I think I would struggle more with the theory-based questions and would have to review my notes from discrete/data structures beforehand.  Part 4 Learning Journal.  Writing material:  For my Ethics essay, I will need to c...
Read more

Week 2

Image
Part 1. The top 3 items I am good at is taking notes, reviewing easy questions on exams first, and setting a schedule. I think one area I could improve on is asking the right questions. Part 2. Log        Part 3 Project Management basics.      Companies have experts that focus on project management. A board of directors will decide on a project to be completed while a project manager essentially acts as CEO over that project. The work breakdown structure is a fundamental tool of project management. It is common to break down projects into its own products/deliverables. To create a work breakdown structure, you create a hierarchical decomposition of all the deliverables. Level 0 is the project. Level 1 is the Keyline (organizing principles). Level 2 is the Major Deliverable. Level 3 is sub-deliverables (helps meet end deliverables). Level 4 and further decompose sub-deliverables. Finally, get feedback before presenting final work breakdown structure. Ea...
Read more